-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hazard Joe Emotes #6005
Merged
Merged
Hazard Joe Emotes #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Feature
Feature coder badge
Code Improvement
Make the code longer
Sound
Blast 5 minutes of bass boosted music to our players
labels
Mar 24, 2024
Drulikar
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All code appears fine and is working.
A few existing WJ lines are quieter than others, but they are not from this PR. However 'sound/voice/joe/what_is_this_haz.ogg'
cuts off too quickly. Please touch up this file if possible.
Drulikar
approved these changes
Mar 26, 2024
cm13-github
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Improvement
Make the code longer
Feature
Feature coder badge
Sound
Blast 5 minutes of bass boosted music to our players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Emotes for Hazard Joes
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Hazard Joes now have their own emotes
code: Hazard Joes now a seperate species
code: Updated isworkingjoe and new ishazardjoe define
refactor: Working Joe emotes and emote categories now a globally defined list
soundadd: New Hazard Joe voicelines
/:cl: