Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazard Joe Emotes #6005

Merged
merged 18 commits into from
Mar 26, 2024
Merged

Hazard Joe Emotes #6005

merged 18 commits into from
Mar 26, 2024

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Mar 24, 2024

About the pull request

Emotes for Hazard Joes

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Hazard Joes now have their own emotes
code: Hazard Joes now a seperate species
code: Updated isworkingjoe and new ishazardjoe define
refactor: Working Joe emotes and emote categories now a globally defined list
soundadd: New Hazard Joe voicelines
/:cl:

@Ben10083 Ben10083 changed the title Hazard Joe Backend, but buggy Hazard Joe Emoets Mar 24, 2024
@Ben10083 Ben10083 changed the title Hazard Joe Emoets Hazard Joe Emotes Mar 24, 2024
@github-actions github-actions bot added Feature Feature coder badge Code Improvement Make the code longer Sound Blast 5 minutes of bass boosted music to our players labels Mar 24, 2024
@Ben10083 Ben10083 marked this pull request as ready for review March 25, 2024 00:53
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code appears fine and is working.

A few existing WJ lines are quieter than others, but they are not from this PR. However 'sound/voice/joe/what_is_this_haz.ogg' cuts off too quickly. Please touch up this file if possible.

@Ben10083 Ben10083 requested a review from Drulikar March 26, 2024 01:21
@Drulikar Drulikar added this pull request to the merge queue Mar 26, 2024
Merged via the queue into cmss13-devs:master with commit 257c2fc Mar 26, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Mar 26, 2024
@Ben10083 Ben10083 deleted the Hazard_Joe_Voicelines branch March 26, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants